Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unused deliveryservice_tmuser table #6430

Merged
merged 3 commits into from
Mar 22, 2022
Merged

Remove unused deliveryservice_tmuser table #6430

merged 3 commits into from
Mar 22, 2022

Conversation

ocket8888
Copy link
Contributor

This PR closes #2910 by removing the now-unused deliveryservice_tmuser table from the TO database.

Which Traffic Control components are affected by this PR?

  • Traffic Ops (database)
  • Traffic Ops client (Go, tests)
  • t3c (tests)

What is the best way to verify this PR?

No known functionality depended on this table, so just ensure existing functionality continues to work.

PR submission checklist

  • This PR has tests
  • This PR has documentation
  • This PR has a CHANGELOG.md entry
  • This PR DOES NOT FIX A SERIOUS SECURITY VULNERABILITY

@ocket8888 ocket8888 added Traffic Ops related to Traffic Ops low impact affects only a small portion of a CDN, and cannot itself break one tech debt rework due to choosing easy/limited solution database relating to setup/installation/structure of the Traffic Ops database labels Dec 16, 2021
@ocket8888 ocket8888 force-pushed the to/remove-ds_tmuser branch 2 times, most recently from 1fffaf3 to f6efdc9 Compare December 16, 2021 22:06
@ocket8888 ocket8888 force-pushed the to/remove-ds_tmuser branch 2 times, most recently from 4593654 to d72de31 Compare March 3, 2022 16:01
mattjackson220
mattjackson220 approved these changes Mar 22, 2022
View reviewed changes
Copy link
Contributor

@mattjackson220 mattjackson220 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changes look good to me! running locally everything seems to run normally with this removed!

@mattjackson220
Copy link
Contributor

test failure is fixed in master and unrelated to this PR

@mattjackson220 mattjackson220 merged commit 43b6ca5 into apache:master Mar 22, 2022
@github-actions github-actions bot mentioned this pull request Apr 1, 2022
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattjackson220 mattjackson220 mattjackson220 approved these changes

Assignees
No one assigned
Labels
database relating to setup/installation/structure of the Traffic Ops database low impact affects only a small portion of a CDN, and cannot itself break one tech debt rework due to choosing easy/limited solution Traffic Ops related to Traffic Ops
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

TO: investigate removing deliveryservice_tmuser table
2 participants
@ocket8888 @mattjackson220